Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: api token creation payload in webhook details modal #2146

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

eshankvaish
Copy link
Contributor

@eshankvaish eshankvaish commented Oct 24, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes https://github.com/devtron-labs/devops-sprint/issues/1161

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@eshankvaish eshankvaish self-assigned this Oct 24, 2024
@github-actions github-actions bot added the PR:Issue-verification-failed PR:Issue-verification-failed label Oct 24, 2024
Copy link

sonarcloud bot commented Oct 24, 2024

@github-actions github-actions bot added PR:Ready-to-Review PR:Ready-to-Review and removed PR:Issue-verification-failed PR:Issue-verification-failed labels Oct 24, 2024
@eshankvaish eshankvaish merged commit 4686e0d into main Oct 24, 2024
11 of 13 checks passed
@eshankvaish eshankvaish deleted the fix/api-token-creation branch October 24, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Ready-to-Review PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants